watchdog: make nowayout sysfs file writable
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Tue, 5 Nov 2019 20:51:18 +0000 (21:51 +0100)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Mon, 18 Nov 2019 18:53:43 +0000 (19:53 +0100)
commitbc44fa734cef28e7ddb26bbf9e75e7f7449c9db2
treee7c5aaf051523dfd27b25f47c377b6cc8093ff72
parenta19f89335f4bda3d77d991c96583e3e51856acbb
watchdog: make nowayout sysfs file writable

It can be useful to delay setting the nowayout feature for a watchdog
device. Moreover, not every driver (notably gpio_wdt) implements a
nowayout module parameter/otherwise respects CONFIG_WATCHDOG_NOWAYOUT,
and modifying those drivers carries a risk of causing a regression for
someone who has two watchdog devices, sets CONFIG_WATCHDOG_NOWAYOUT
and somehow relies on the gpio_wdt driver being ignorant of
that (i.e., allowing one to gracefully close a gpio_wdt but not the
other watchdog in the system).

So instead, simply make the nowayout sysfs file writable. Obviously,
setting nowayout is a one-way street.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20191105205118.11359-1-linux@rasmusvillemoes.dk
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Documentation/ABI/testing/sysfs-class-watchdog
drivers/watchdog/watchdog_dev.c