PCI/sysfs: Fix dsm_label_utf16s_to_utf8s() buffer overrun
authorKrzysztof Wilczyński <kw@linux.com>
Thu, 3 Jun 2021 00:01:12 +0000 (00:01 +0000)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 3 Jun 2021 21:45:42 +0000 (16:45 -0500)
commitbdcdaa13ad96f1a530711c29e6d4b8311eff767c
treebdf6692dd43497f8710e3ec360564ef9a1f70098
parent6efb943b8616ec53a5e444193dccf1af9ad627b5
PCI/sysfs: Fix dsm_label_utf16s_to_utf8s() buffer overrun

"utf16s_to_utf8s(..., buf, PAGE_SIZE)" puts up to PAGE_SIZE bytes into
"buf" and returns the number of bytes it actually put there.  If it wrote
PAGE_SIZE bytes, the newline added by dsm_label_utf16s_to_utf8s() would
overrun "buf".

Reduce the size available for utf16s_to_utf8s() to use so there is always
space for the newline.

[bhelgaas: reorder patch in series, commit log]
Fixes: 6058989bad05 ("PCI: Export ACPI _DSM provided firmware instance number and string name to sysfs")
Link: https://lore.kernel.org/r/20210603000112.703037-7-kw@linux.com
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/pci-label.c