bcachefs: Fix race leading to btree node write getting stuck
authorKent Overstreet <kent.overstreet@gmail.com>
Sun, 27 Feb 2022 14:56:33 +0000 (09:56 -0500)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:09:26 +0000 (17:09 -0400)
commitbf3efff5e4fc2dcd6e6c15578d3f08c301a13229
treecca40f2591a81ba52e14350a663266b83c78e43f
parent6f5f747c318be4adf3824ee7716a7886da35f9a3
bcachefs: Fix race leading to btree node write getting stuck

Checking btree_node_may_write() isn't atomic with the other btree flags,
dirty and need_write in particular. There was a rare race where we'd
unblock a node from writing while __btree_node_flush() was setting
need_write, and no thread would notice that the node was now both able
to write and needed to be written.

Fix this by adding btree node flags for will_make_reachable and
write_blocked that can be checked in the cmpxchg loop in
__bch2_btree_node_write.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
fs/bcachefs/btree_cache.c
fs/bcachefs/btree_io.c
fs/bcachefs/btree_io.h
fs/bcachefs/btree_types.h
fs/bcachefs/btree_update_interior.c