media: mediatek: vcodec: avoid -Wcast-function-type-strict warning
authorArnd Bergmann <arnd@arndb.de>
Sat, 24 Feb 2024 12:10:22 +0000 (13:10 +0100)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 28 Feb 2024 15:00:33 +0000 (16:00 +0100)
commitbfb1b99802ef16045402deb855c197591dc78886
tree1894435cc7e33c2670718ae5db4c0930cc0d0fe1
parentd0b07f712bf61e1a3cf23c87c663791c42e50837
media: mediatek: vcodec: avoid -Wcast-function-type-strict warning

The ipi handler here tries hard to maintain const-ness of its argument,
but by doing that causes a warning about function type casts:

drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c:38:32: error: cast from 'mtk_vcodec_ipi_handler' (aka 'void (*)(void *, unsigned int, void *)') to 'ipi_handler_t' (aka 'void (*)(const void *, unsigned int, void *)') converts to incompatible function type [-Werror,-Wcast-function-type-strict]
   38 |         ipi_handler_t handler_const = (ipi_handler_t)handler;
      |                                       ^~~~~~~~~~~~~~~~~~~~~~

Remove the hack and just use a non-const argument.

Fixes: bf1d556ad4e0 ("media: mtk-vcodec: abstract firmware interface")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/platform/mediatek/mdp/mtk_mdp_vpu.c
drivers/media/platform/mediatek/vcodec/common/mtk_vcodec_fw_vpu.c
drivers/media/platform/mediatek/vpu/mtk_vpu.c
drivers/media/platform/mediatek/vpu/mtk_vpu.h