tools: ynl-gen: change spacing around __attribute__
authorJakub Kicinski <kuba@kernel.org>
Fri, 20 Oct 2023 22:18:27 +0000 (15:18 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Oct 2023 17:15:36 +0000 (10:15 -0700)
commitc0119e62b2fe990a512a5ab8fb7c30e28fa619b8
tree33ca9c6fc080539e9a41fab164b62c85927c3cd8
parentb7c4f5730a9fa258c8e79f6387a03f3a95c681a2
tools: ynl-gen: change spacing around __attribute__

checkpatch gets confused and treats __attribute__ as a function call.
It complains about white space before "(":

WARNING:SPACING: space prohibited between function name and open parenthesis '('
+ struct netdev_queue_get_rsp obj __attribute__ ((aligned (8)));

No spaces wins in the kernel:

  $ git grep 'attribute__((.*aligned(' | wc -l
  480
  $ git grep 'attribute__ ((.*aligned (' | wc -l
  110
  $ git grep 'attribute__ ((.*aligned(' | wc -l
  94
  $ git grep 'attribute__((.*aligned (' | wc -l
  63

So, whatever, change the codegen.

Note that checkpatch also thinks we should use __aligned(),
but this is user space code.

Link: https://lore.kernel.org/all/202310190900.9Dzgkbev-lkp@intel.com/
Acked-by: Stanislav Fomichev <sdf@google.com>
Reviewed-by: Amritha Nambiar <amritha.nambiar@intel.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20231020221827.3436697-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/net/ynl/generated/devlink-user.h
tools/net/ynl/generated/ethtool-user.h
tools/net/ynl/generated/fou-user.h
tools/net/ynl/generated/handshake-user.h
tools/net/ynl/generated/netdev-user.h
tools/net/ynl/lib/ynl.h
tools/net/ynl/ynl-gen-c.py