f2fs: avoid attaching SB_ACTIVE flag during mount
authorChao Yu <chao@kernel.org>
Wed, 1 Sep 2021 08:06:21 +0000 (16:06 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 16 Sep 2021 15:38:32 +0000 (08:38 -0700)
commitc02599f210d90c76e42e2eb544511a47cceb60c9
tree53a4732f3b029858fad973423141fc5b285db372
parenta5c0042200b28fff3bde6fa128ddeaef97990f8d
f2fs: avoid attaching SB_ACTIVE flag during mount

Quoted from [1]

"I do remember that I've added this code back then because otherwise
orphan cleanup was losing updates to quota files. But you're right
that now I don't see how that could be happening and it would be nice
if we could get rid of this hack"

[1] https://lore.kernel.org/linux-ext4/99cce8ca-e4a0-7301-840f-2ace67c551f3@huawei.com/T/#m04990cfbc4f44592421736b504afcc346b2a7c00

Related fix in ext4 by
commit 72ffb49a7b62 ("ext4: do not set SB_ACTIVE in ext4_orphan_cleanup()").

f2fs has the same hack implementation in
- f2fs_recover_orphan_inodes()
- f2fs_recover_fsync_data()

Let's get rid of this hack as well in f2fs.

Cc: Zhang Yi <yi.zhang@huawei.com>
Cc: Jan Kara <jack@suse.cz>
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/checkpoint.c
fs/f2fs/recovery.c