f2fs: remove unnecessary f2fs_put_page in f2fs_rename
authorJaegeuk Kim <jaegeuk@kernel.org>
Fri, 12 Jan 2024 17:11:13 +0000 (09:11 -0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 6 Feb 2024 02:58:38 +0000 (18:58 -0800)
commitc10e8558d49d4ec62d78af1cf2852a1640bea9f7
tree5c77d8b8bd2ca5b3a7ad71e47a5b862c7828d714
parent54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
f2fs: remove unnecessary f2fs_put_page in f2fs_rename

[1] changed the below condition, which made f2fs_put_page() voided.
This patch reapplies the AL's resolution in -next from [2].

-       if (S_ISDIR(old_inode->i_mode)) {
+       if (old_is_dir && old_dir != new_dir) {
                old_dir_entry = f2fs_parent_dir(old_inode, &old_dir_page);
                if (!old_dir_entry) {
                        if (IS_ERR(old_dir_page))

[1] 7deee77b993a ("f2fs: Avoid reading renamed directory if parent does not change")
[2] https://lore.kernel.org/all/20231220013402.GW1674809@ZenIV/

Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/namei.c