remoteproc: qcom: Fix potential NULL dereference in adsp_init_mmio()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Tue, 8 Dec 2020 01:54:20 +0000 (09:54 +0800)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Thu, 10 Dec 2020 19:28:08 +0000 (13:28 -0600)
commitc3d4e5b12672bbdf63f4cc933e3169bc6bbec8da
treebfaed931b91efbedf9bb40e633f8cf7b6edb2a69
parentcca21000261b2364991ecdb0d9e66b26ad9c4b4e
remoteproc: qcom: Fix potential NULL dereference in adsp_init_mmio()

platform_get_resource() may fail and in this case a NULL dereference
will occur.

Fix it to use devm_platform_ioremap_resource() instead of calling
platform_get_resource() and devm_ioremap().

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = \(platform_get_resource\|platform_get_resource_byname\)(pdev, t,
n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Fixes: dc160e449122 ("remoteproc: qcom: Introduce Non-PAS ADSP PIL driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Link: https://lore.kernel.org/r/1607392460-20516-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/remoteproc/qcom_q6v5_adsp.c