x86/fred: Fix init_task thread stack pointer initialization
authorXin Li (Intel) <xin@zytor.com>
Mon, 4 Mar 2024 08:33:33 +0000 (00:33 -0800)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 7 Mar 2024 10:55:36 +0000 (11:55 +0100)
commitc416b5bac6ad6ffe21e36225553b82ff2ec1558c
tree46827e73fce51e923a6015cd74b7fe1904f91577
parente13841907b8fda0ae0ce1ec03684665f578416a8
x86/fred: Fix init_task thread stack pointer initialization

As TOP_OF_KERNEL_STACK_PADDING was defined as 0 on x86_64, it went
unnoticed that the initialization of the .sp field in INIT_THREAD and some
calculations in the low level startup code do not take the padding into
account.

FRED enabled kernels require a 16 byte padding, which means that the init
task initialization and the low level startup code use the wrong stack
offset.

Subtract TOP_OF_KERNEL_STACK_PADDING in all affected places to adjust for
this.

Fixes: 65c9cc9e2c14 ("x86/fred: Reserve space for the FRED stack frame")
Fixes: 3adee777ad0d ("x86/smpboot: Remove initial_stack on 64-bit")
Reported-by: kernel test robot <oliver.sang@intel.com>
Signed-off-by: Xin Li (Intel) <xin@zytor.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/oe-lkp/202402262159.183c2a37-lkp@intel.com
Link: https://lore.kernel.org/r/20240304083333.449322-1-xin@zytor.com
arch/x86/include/asm/processor.h
arch/x86/kernel/head_64.S
arch/x86/xen/xen-head.S