serial: stm32: Re-assert RTS/DE GPIO in RS485 mode only if more data are transmitted
authorMarek Vasut <marex@denx.de>
Thu, 23 Feb 2023 04:22:52 +0000 (05:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Mar 2023 16:16:11 +0000 (17:16 +0100)
commitc47527cbcc3c50800f34b8c684f29721f75de246
tree510c9fe502f2222c31f6931304fb9530e4404ef9
parentb4fd0afaa07f9f46c733e7cf17e4b4cb45461c3c
serial: stm32: Re-assert RTS/DE GPIO in RS485 mode only if more data are transmitted

The stm32_usart_transmit_chars() may be called with empty or stopped
transmit queue, and no XON/OFF character pending. This can happen at
the end of transmission, where this last call is used to either handle
the XON/XOFF x_char, or disable TX interrupt if queue is empty or
stopped.

If that occurs, do not assert the RS485 RTS/DE GPIO anymore, as the
GPIO would remain asserted past the end of transmission and that would
block the RS485 bus after the transmission.

Only assert the RS485 RTS/DE GPIO if there is either pending XON/XOFF
x_char, or at least one character in running transmit queue.

Fixes: d7c76716169d ("serial: stm32: Use TC interrupt to deassert GPIO RTS in RS485 mode")
Signed-off-by: Marek Vasut <marex@denx.de>
Link: https://lore.kernel.org/r/20230223042252.95480-2-marex@denx.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/stm32-usart.c