exec: Call kmap_local_page() in copy_string_kernel()
authorFabio M. De Francesco <fmdefrancesco@gmail.com>
Sun, 24 Jul 2022 21:25:23 +0000 (23:25 +0200)
committerKees Cook <keescook@chromium.org>
Wed, 27 Jul 2022 21:15:09 +0000 (14:15 -0700)
commitc6e8e36c6ae4b11bed5643317afb66b6c3cadba8
treed00ed947848a3c17a423d1f0f7734858479716a3
parent5036793d7dbd0b14aec51526441a50b01c7bf66d
exec: Call kmap_local_page() in copy_string_kernel()

The use of kmap_atomic() is being deprecated in favor of kmap_local_page().

With kmap_local_page(), the mappings are per thread, CPU local and not
globally visible. Furthermore, the mappings can be acquired from any
context (including interrupts).

Therefore, replace kmap_atomic() with kmap_local_page() in
copy_string_kernel(). Instead of open-coding local mapping + memcpy(),
use memcpy_to_page(). Delete a redundant call to flush_dcache_page().

Tested with xfstests on a QEMU/ KVM x86_32 VM, 6GB RAM, booting a kernel
with HIGHMEM64GB enabled.

Suggested-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20220724212523.13317-1-fmdefrancesco@gmail.com
fs/exec.c