ravb: Fix "failed to switch device to config mode" message during unbind
authorBiju Das <biju.das.jz@bp.renesas.com>
Wed, 14 Dec 2022 10:51:18 +0000 (10:51 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 15 Dec 2022 14:36:05 +0000 (15:36 +0100)
commitc72a7e42592b2e18d862cf120876070947000d7a
treef60147b5bb8376a2cf742408b20ce07f2a82fd9c
parent2cb815cfc78b137ee38bcd65e7c955d6cc2cc250
ravb: Fix "failed to switch device to config mode" message during unbind

This patch fixes the error "ravb 11c20000.ethernet eth0: failed to switch
device to config mode" during unbind.

We are doing register access after pm_runtime_put_sync().

We usually do cleanup in reverse order of init. Currently in
remove(), the "pm_runtime_put_sync" is not in reverse order.

Probe
reset_control_deassert(rstc);
pm_runtime_enable(&pdev->dev);
pm_runtime_get_sync(&pdev->dev);

remove
pm_runtime_put_sync(&pdev->dev);
unregister_netdev(ndev);
..
ravb_mdio_release(priv);
pm_runtime_disable(&pdev->dev);

Consider the call to unregister_netdev()
unregister_netdev->unregister_netdevice_queue->rollback_registered_many
that calls the below functions which access the registers after
pm_runtime_put_sync()
 1) ravb_get_stats
 2) ravb_close

Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper")
Cc: stable@vger.kernel.org
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/20221214105118.2495313-1-biju.das.jz@bp.renesas.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/renesas/ravb_main.c