pinctrl: at91-pio4: drop useless check in atmel_conf_pin_config_dbg_show()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Wed, 2 Aug 2023 20:47:46 +0000 (23:47 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 10 Aug 2023 08:10:01 +0000 (10:10 +0200)
commitc7351b46d0da5f0f1bc35187a3c924bface884e0
tree5d2a62e18e34a289716809c99528a27239d9b195
parent137062f11ce0bed784cb6ac8310cf6aa723b2427
pinctrl: at91-pio4: drop useless check in atmel_conf_pin_config_dbg_show()

In atmel_conf_pin_config_dbg_show(), checking atmel_pioctrl->pins[pin_id]
against being NULL doesn't make any sense as it gets derefenced first and
the driver's probe() method immediately returns -ENOMEM when devm_kzalloc()
returns NULL for any atmel_pioctrl->pins[] element anyway, thus failing to
register the device...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/4ab2f59f-45c1-76a2-94da-3331e8ec4e35@omp.ru
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-at91-pio4.c