futex: Don't include process MM in futex key on no-MMU
authorBen Wolsieffer <ben.wolsieffer@hefring.com>
Thu, 19 Oct 2023 20:45:49 +0000 (16:45 -0400)
committerIngo Molnar <mingo@kernel.org>
Fri, 27 Oct 2023 09:53:42 +0000 (11:53 +0200)
commitc73801ae4f22b390228ebf471d55668e824198b6
tree3ff2d2f1871b78a9f626c9457a421e3ea4343fe4
parent184fdf9fc7ae6ae7155768faa48fc609d1a24b7e
futex: Don't include process MM in futex key on no-MMU

On no-MMU, all futexes are treated as private because there is no need
to map a virtual address to physical to match the futex across
processes. This doesn't quite work though, because private futexes
include the current process's mm_struct as part of their key. This makes
it impossible for one process to wake up a shared futex being waited on
in another process.

Fix this bug by excluding the mm_struct from the key. With
a single address space, the futex address is already a unique key.

Fixes: 784bdf3bb694 ("futex: Assume all mappings are private on !MMU systems")
Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: André Almeida <andrealmeid@igalia.com>
Link: https://lore.kernel.org/r/20231019204548.1236437-2-ben.wolsieffer@hefring.com
kernel/futex/core.c