scsi: sd: Fix sshdr use in cache_type_store
authorMike Christie <michael.christie@oracle.com>
Wed, 4 Oct 2023 21:00:12 +0000 (16:00 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 20:36:20 +0000 (16:36 -0400)
commitc8b7ef36da0372d52e55cd1b7f1ac2b285eb2680
tree0fc0591db48daac59e044fbef335a40d1d2e7388
parent8f0017694c54e4a9b576b12562894e1c8047342f
scsi: sd: Fix sshdr use in cache_type_store

If scsi_execute_cmd returns < 0, it doesn't initialize the sshdr, so we
shouldn't access the sshdr. If it returns 0, then the cmd executed
successfully, so there is no need to check the sshdr. This has us access
the sshdr when we get a return value > 0.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
Link: https://lore.kernel.org/r/20231004210013.5601-12-michael.christie@oracle.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c