RDMA/srp: Rework the srp_add_port() error path
authorBart Van Assche <bvanassche@acm.org>
Thu, 25 Aug 2022 21:38:57 +0000 (14:38 -0700)
committerLeon Romanovsky <leonro@nvidia.com>
Sun, 28 Aug 2022 10:02:04 +0000 (13:02 +0300)
commitc8e4c23976554fb9dda1658bd1a3914b202815cd
treef803350df7c4823125c1e7033b56f7e8a50b29d2
parent3d67e7e236adb4965ff9834bb7125686ecf9654a
RDMA/srp: Rework the srp_add_port() error path

device_register() always calls device_initialize() so calling device_del()
is safe even if device_register() fails. Implement the following advice
from the comment block above device_register(): "NOTE: _Never_ directly free
@dev after calling this function, even if it returned an error! Always use
put_device() to give up the reference initialized in this function instead."
Keep the kfree() call in the error path since srp_release_dev() does not
free the host.

Link: https://lore.kernel.org/r/20220825213900.864587-2-bvanassche@acm.org
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/ulp/srp/ib_srp.c