gfs2: Fix duplicate should_fault_in_pages() call
authorBob Peterson <rpeterso@redhat.com>
Mon, 12 Jun 2023 17:26:23 +0000 (12:26 -0500)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 12 Jun 2023 18:04:35 +0000 (20:04 +0200)
commitc8ed1b35931245087968fd95b2ec3dfc50f77769
tree692ee2f38c2a74bd3f4a26e85f0a34faed3efb0d
parent7b7b06d55aeff969ffdfd1170937198f7c02b684
gfs2: Fix duplicate should_fault_in_pages() call

In gfs2_file_buffered_write(), we currently jump from the second call of
function should_fault_in_pages() to above the first call, so
should_fault_in_pages() is getting called twice in a row, causing it to
accidentally fall back to single-page writes rather than trying the more
efficient multi-page writes first.

Fix that by moving the retry label to the correct place, behind the
first call to should_fault_in_pages().

Fixes: e1fa9ea85ce8 ("gfs2: Stop using glock holder auto-demotion for now")
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/file.c