interconnect: qcom: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 15 Oct 2023 13:59:56 +0000 (15:59 +0200)
committerGeorgi Djakov <djakov@kernel.org>
Wed, 18 Oct 2023 10:37:39 +0000 (13:37 +0300)
commitc8fd5a37340f9dfb02f7c340d7b602bd2f7ec449
treec3cf8ea3f89a1be74255208a471dd0ee7726235e
parent3642b4e5cbfe480892858f0209c6fd0a3172a103
interconnect: qcom: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Several drivers use qcom_icc_rpmh_remove() as remove callback which
returns zero unconditionally. Make it return void and use .remove_new in
the drivers. There is no change in behaviour.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20231015135955.1537751-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Georgi Djakov <djakov@kernel.org>
19 files changed:
drivers/interconnect/qcom/icc-rpmh.c
drivers/interconnect/qcom/icc-rpmh.h
drivers/interconnect/qcom/qdu1000.c
drivers/interconnect/qcom/sa8775p.c
drivers/interconnect/qcom/sc7180.c
drivers/interconnect/qcom/sc7280.c
drivers/interconnect/qcom/sc8180x.c
drivers/interconnect/qcom/sc8280xp.c
drivers/interconnect/qcom/sdm670.c
drivers/interconnect/qcom/sdm845.c
drivers/interconnect/qcom/sdx55.c
drivers/interconnect/qcom/sdx65.c
drivers/interconnect/qcom/sdx75.c
drivers/interconnect/qcom/sm6350.c
drivers/interconnect/qcom/sm8150.c
drivers/interconnect/qcom/sm8250.c
drivers/interconnect/qcom/sm8350.c
drivers/interconnect/qcom/sm8450.c
drivers/interconnect/qcom/sm8550.c