drm/i915: Fully populate crtc_state->dpll
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 5 Jul 2023 20:21:14 +0000 (23:21 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 24 Aug 2023 12:24:12 +0000 (15:24 +0300)
commitc99c0e2839a43f51b9d29b6c782d8bc4f4ecf091
tree402e58e72fac62d0daf1ed7b1d920ae97d039391
parent7176dca94314bada5b715611b2a54630ee68e48f
drm/i915: Fully populate crtc_state->dpll

Call *_calc_dpll_params() even in cases where the encoder has
computed the DPLL params for us.

The SDVO TV output code doesn't populate crtc_state->dpll.dot
leading to the dotclock getting calculated as zero, and that
leads to all kinds of real problems. The g4x DP code also
doesn't populate the derived dividers nor .vco, which could
also create some confusion.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230705202122.17915-6-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_dpll.c