Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load
authorTaylor Simpson <tsimpson@quicinc.com>
Thu, 7 Jul 2022 21:05:45 +0000 (14:05 -0700)
committerTaylor Simpson <tsimpson@quicinc.com>
Tue, 19 Jul 2022 21:20:08 +0000 (14:20 -0700)
commitcab86dea1d205f5224770de294cc718be467ccf8
tree00f2897d348a7ed117bc32f776ea256226cdaa86
parentd48125de38f48a61d6423ef6a01156d6dff9ee2c
Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load

Call the CHECK_NOSHUF macro multiple times: once in the
fGEN_TCG_PRED_LOAD() and again in fLOAD().

Before this commit, a packet with a store and a predicated
load with mem_noshuf that gets encoded like this:

    { P0 = cmp.eq(R17,#0x0)
      memw(R18+#0x0) = R2
      if (!P0.new) R3 = memw(R17+#0x4) }

... would end up generating a branch over both the load
and the store like so:

    ...
    brcond_i32 loc17,$0x0,eq,$L1
    mov_i32 loc18,store_addr_1
    qemu_st_i32 store_val32_1,store_addr_1,leul,0
    qemu_ld_i32 loc16,loc7,leul,0
    set_label $L1
    ...

Test cases added to tests/tcg/hexagon/mem_noshuf.c

Co-authored-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Brian Cain <bcain@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220707210546.15985-2-tsimpson@quicinc.com>
target/hexagon/gen_tcg.h
tests/tcg/hexagon/mem_noshuf.c