ethtool: don't propagate EOPNOTSUPP from dumps
authorJakub Kicinski <kuba@kernel.org>
Sun, 26 Nov 2023 22:58:06 +0000 (14:58 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 29 Nov 2023 16:43:27 +0000 (08:43 -0800)
commitcbeb989e41f4094f54bec2cecce993f26f547bea
tree9b9f83c84586dd5d3d0ec913258b148eb8f0e17b
parent9870257a0a338cd8d6c1cddab74e703f490f6779
ethtool: don't propagate EOPNOTSUPP from dumps

The default dump handler needs to clear ret before returning.
Otherwise if the last interface returns an inconsequential
error this error will propagate to user space.

This may confuse user space (ethtool CLI seems to ignore it,
but YNL doesn't). It will also terminate the dump early
for mutli-skb dump, because netlink core treats EOPNOTSUPP
as a real error.

Fixes: 728480f12442 ("ethtool: default handlers for GET requests")
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20231126225806.2143528-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/netlink.c