rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow
authorNikita Kiryushin <kiryushin@ancud.ru>
Wed, 27 Mar 2024 17:47:47 +0000 (20:47 +0300)
committerUladzislau Rezki (Sony) <urezki@gmail.com>
Mon, 15 Apr 2024 17:36:55 +0000 (19:36 +0200)
commitcc5645fddb0ce28492b15520306d092730dffa48
treef5a4ecc1527210842c28ff5f7a05d80254d6a7bd
parent5f48fa85fdb92569f58374b6e040c956628fdcf5
rcu-tasks: Fix show_rcu_tasks_trace_gp_kthread buffer overflow

There is a possibility of buffer overflow in
show_rcu_tasks_trace_gp_kthread() if counters, passed
to sprintf() are huge. Counter numbers, needed for this
are unrealistically high, but buffer overflow is still
possible.

Use snprintf() with buffer size instead of sprintf().

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: edf3775f0ad6 ("rcu-tasks: Add count for idle tasks on offline CPUs")
Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
kernel/rcu/tasks.h