selftests: mptcp: simult flows: mark 'unbalanced' tests as flaky
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Fri, 24 May 2024 16:30:57 +0000 (18:30 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 28 May 2024 00:12:50 +0000 (17:12 -0700)
commitcc73a6577ae64247898269d138dee6b73ff710cc
treeb2014d1f3f20ab8b7edc631ab56f830f9aa17c9a
parent5597613fb3cf0e36d26cfd8fb2a63196da249333
selftests: mptcp: simult flows: mark 'unbalanced' tests as flaky

These tests are flaky since their introduction. This might be less or
not visible depending on the CI running the tests, especially if it is
also busy doing other tasks in parallel.

A first analysis shown that the transfer can be slowed down when there
are some re-injections at the MPTCP level. Such re-injections can of
course happen, and disturb the transfer, but it looks strange to have
them in this lab. That could be caused by the kernel having access to
less CPU cycles -- e.g. when other activities are executed in parallel
-- or by a misinterpretation on the MPTCP packet scheduler side.

While this is being investigated, the tests are marked as flaky not to
create noises in other CIs.

Fixes: 219d04992b68 ("mptcp: push pending frames when subflow has free space")
Link: https://github.com/multipath-tcp/mptcp_net-next/issues/475
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240524-upstream-net-20240524-selftests-mptcp-flaky-v1-2-a352362f3f8e@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/mptcp/simult_flows.sh