nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by
authorKees Cook <keescook@chromium.org>
Thu, 5 Oct 2023 16:14:12 +0000 (09:14 -0700)
committerKeith Busch <kbusch@kernel.org>
Thu, 5 Oct 2023 16:29:04 +0000 (09:29 -0700)
commitccd3129aca286c41616afe357e3494c5b43350a0
tree8534fbb6ea918c23800e0ad3d5dfc322ed092b9a
parent5e9b7cfc209b84d135993b8cb75ea383f24b2bba
nvmet-fc: Annotate struct nvmet_fc_tgt_queue with __counted_by

Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for
array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct
nvmet_fc_tgt_queue. Additionally, since the element count member must
be set before accessing the annotated flexible array member, move its
initialization earlier.

Cc: James Smart <james.smart@broadcom.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/target/fc.c