Revert "sh_eth: remove open coded netif_running()"
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 27 Mar 2023 15:21:12 +0000 (17:21 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 29 Mar 2023 02:23:32 +0000 (19:23 -0700)
commitcdeccd13a03fc6e97c090c12a27566d02dace6d9
tree461f0e9ebc1ded07254ec3594bf7d38f773ce073
parent2600badfea0d78b90a3583b52bc2858bbbc21a05
Revert "sh_eth: remove open coded netif_running()"

This reverts commit ce1fdb065695f49ef6f126d35c1abbfe645d62d5. It turned
out this actually introduces a race condition. netif_running() is not a
suitable check for get_stats.

Reported-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230327152112.15635-1-wsa+renesas@sang-engineering.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/renesas/sh_eth.c
drivers/net/ethernet/renesas/sh_eth.h