pidfd: cleanup the usage of __pidfd_prepare's flags
authorOleg Nesterov <oleg@redhat.com>
Thu, 25 Jan 2024 16:17:34 +0000 (17:17 +0100)
committerChristian Brauner <brauner@kernel.org>
Fri, 2 Feb 2024 12:12:28 +0000 (13:12 +0100)
commitcdefbf2324ceda662e2667aa2f44e8b9de3d780f
treea5b9cff87110f6d621da9f87d2fe759ad02c2d33
parentb639585e71e63008373d3a9fd060b87315fe7ea8
pidfd: cleanup the usage of __pidfd_prepare's flags

- make pidfd_create() static.

- Don't pass O_RDWR | O_CLOEXEC to __pidfd_prepare() in copy_process(),
  __pidfd_prepare() adds these flags unconditionally.

- Kill the flags check in __pidfd_prepare(). sys_pidfd_open() checks the
  flags itself, all other users of pidfd_prepare() pass flags = 0.

  If we need a sanity check for those other in kernel users then
  WARN_ON_ONCE(flags & ~PIDFD_NONBLOCK) makes more sense.

- Don't pass O_RDWR to get_unused_fd_flags(), it ignores everything except
  O_CLOEXEC.

- Don't pass O_CLOEXEC to anon_inode_getfile(), it ignores everything except
  O_ACCMODE | O_NONBLOCK.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20240125161734.GA778@redhat.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
include/linux/pid.h
kernel/fork.c
kernel/pid.c