ovl: Add comment on upperredirect reassignment
authorStanislav Goriainov <goriainov@ispras.ru>
Wed, 31 Aug 2022 08:06:58 +0000 (11:06 +0300)
committerMiklos Szeredi <mszeredi@redhat.com>
Thu, 8 Dec 2022 09:49:46 +0000 (10:49 +0100)
commitcf4ef7801a8c880902a07712ba7ff61d8e954f85
tree4e3ca6541e4b7cd47d6d60ed2acc8d2f7128311b
parentaf4dcb6d78b2b05a0431dfd3f67713bba8dc0900
ovl: Add comment on upperredirect reassignment

If memory for uperredirect was allocated with kstrdup() in upperdir != NULL
and d.redirect != NULL path, it may seem that it can be lost when
upperredirect is reassigned later, but it's not possible.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0a2d0d3f2f291 ("ovl: Check redirect on index as well")
Signed-off-by: Stanislav Goriainov <goriainov@ispras.ru>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/namei.c