ASoC: soc-component: merge snd_soc_component_read() and snd_soc_component_read32()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tue, 16 Jun 2020 05:19:41 +0000 (14:19 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 22 Jun 2020 14:13:36 +0000 (15:13 +0100)
commitcf6e26c71bfdff823fd40945b07666d75f1e1412
tree442165e2d0a1605c68d5b3522772790e95afaa3c
parent3bd057c8219d4006f2b436cea2ae5ac723067a51
ASoC: soc-component: merge snd_soc_component_read() and snd_soc_component_read32()

We had read/write function for Codec, Platform, etc,
but these has been merged into snd_soc_component_read/write().

Internally, it is using regmap or driver function.
In read case, each styles are like below

regmap
ret = regmap_read(..., reg, &val);

driver function
val = xxx->read(..., reg);

Because of this kind of different style, to keep same read style,
when we merged each read function into snd_soc_component_read(),
we created snd_soc_component_read32(), like below.
commit 738b49efe6c6 ("ASoC: add snd_soc_component_read32")

(1) val = snd_soc_component_read32(component, reg);

(2) ret = snd_soc_component_read(component, reg, &val);

Many drivers are using snd_soc_component_read32(), and
some drivers are using snd_soc_component_read() today.

In generally, we don't check read function successes,
because, we will have many other issues at initial timing
if read function didn't work.

Now we can use soc_component_err() when error case.
This means, it is easy to notice if error occurred.

This patch aggressively merge snd_soc_component_read() and _read32(),
and makes snd_soc_component_read/write() as generally style.

This patch do
1) merge snd_soc_component_read() and snd_soc_component_read32()
2) it uses soc_component_err() when error case (easy to notice)
3) keeps read32 for now by #define
4) update snd_soc_component_read() for all drivers

Because _read() user drivers are not too many, this patch changes
all user drivers.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/87sgev4mfl.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
21 files changed:
include/sound/soc-component.h
sound/soc/codecs/ak4613.c
sound/soc/codecs/cs47l35.c
sound/soc/codecs/cs47l85.c
sound/soc/codecs/inno_rk3036.c
sound/soc/codecs/madera.c
sound/soc/codecs/nau8822.c
sound/soc/codecs/rt1305.c
sound/soc/codecs/rt5682.c
sound/soc/codecs/tas5720.c
sound/soc/codecs/tda7419.c
sound/soc/codecs/tscs454.c
sound/soc/fsl/fsl_audmix.c
sound/soc/fsl/fsl_easrc.c
sound/soc/meson/aiu-encoder-i2s.c
sound/soc/meson/aiu-fifo-i2s.c
sound/soc/meson/aiu-fifo.c
sound/soc/soc-ac97.c
sound/soc/soc-component.c
sound/soc/soc-dapm.c
sound/soc/soc-ops.c