kcsan: Change data_race() to no longer require marking racing accesses
authorMarco Elver <elver@google.com>
Tue, 31 Mar 2020 19:32:33 +0000 (21:32 +0200)
committerPaul E. McKenney <paulmck@kernel.org>
Tue, 14 Apr 2020 00:18:15 +0000 (17:18 -0700)
commitd071e91361bbfef524ae8abf7e560fb294d0ad64
treeb49bfa0fec727aeb9f787950bd8bb69e2458e854
parent01b4ff58f72dbee926077d9afa0650f6e685e866
kcsan: Change data_race() to no longer require marking racing accesses

Thus far, accesses marked with data_race() would still require the
racing access to be marked in some way (be it with READ_ONCE(),
WRITE_ONCE(), or data_race() itself), as otherwise KCSAN would still
report a data race.  This requirement, however, seems to be unintuitive,
and some valid use-cases demand *not* marking other accesses, as it
might hide more serious bugs (e.g. diagnostic reads).

Therefore, this commit changes data_race() to no longer require marking
racing accesses (although it's still recommended if possible).

The alternative would have been introducing another variant of
data_race(), however, since usage of data_race() already needs to be
carefully reasoned about, distinguishing between these cases likely adds
more complexity in the wrong place.

Link: https://lkml.kernel.org/r/20200331131002.GA30975@willie-the-truck
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Will Deacon <will@kernel.org>
Cc: Qian Cai <cai@lca.pw>
Acked-by: Will Deacon <will@kernel.org>
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
include/linux/compiler.h