kdb: Fix pager search for multi-line strings
authorDaniel Thompson <daniel.thompson@linaro.org>
Wed, 9 Sep 2020 14:17:08 +0000 (15:17 +0100)
committerDaniel Thompson <daniel.thompson@linaro.org>
Thu, 1 Oct 2020 13:44:08 +0000 (14:44 +0100)
commitd081a6e353168f15e63eb9e9334757f20343319f
tree1f58904a23ee4690b2ed9ea4ae8e50d30ad6882d
parent771910f719651789adee8260e1a2c4c0ba161007
kdb: Fix pager search for multi-line strings

Currently using forward search doesn't handle multi-line strings correctly.
The search routine replaces line breaks with \0 during the search and, for
regular searches ("help | grep Common\n"), there is code after the line
has been discarded or printed to replace the break character.

However during a pager search ("help\n" followed by "/Common\n") when the
string is matched we will immediately return to normal output and the code
that should restore the \n becomes unreachable. Fix this by restoring the
replaced character when we disable the search mode and update the comment
accordingly.

Fixes: fb6daa7520f9d ("kdb: Provide forward search at more prompt")
Link: https://lore.kernel.org/r/20200909141708.338273-1-daniel.thompson@linaro.org
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
kernel/debug/kdb/kdb_io.c