serial: core: Don't drop port_mutex in serial_core_remove_one_port
authorSteven Price <steven.price@arm.com>
Thu, 1 Jun 2023 10:55:48 +0000 (11:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Jun 2023 13:04:01 +0000 (14:04 +0100)
commitd0a396083e91e3f118c90afa95c91f8c243a6c11
treebaf4fa3ccf8c923bd6bdf7631173c061736b8e12
parent84a9582fd203063cd4d301204971ff2cd8327f1a
serial: core: Don't drop port_mutex in serial_core_remove_one_port

Commit 84a9582fd203 ("serial: core: Start managing serial controllers to
enable runtime PM") required the caller to hold port_mutex rather than
taking it locally. However the mutex_unlock() call wasn't removed
causing the mutex to be dropped unexpectly. Remove the call to
mutex_unlock() (and fix up the early return) to restore correct
behaviour.

Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
Signed-off-by: Steven Price <steven.price@arm.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230601105548.29965-1-steven.price@arm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/serial_core.c