ARM: mvebu: declare asm symbols as character arrays in pmsu.c
authorEthan Tuttle <ethan@ethantuttle.com>
Wed, 20 Jun 2018 04:31:08 +0000 (21:31 -0700)
committerGregory CLEMENT <gregory.clement@bootlin.com>
Wed, 27 Jun 2018 06:15:12 +0000 (08:15 +0200)
commitd0d378ff451a66e486488eec842e507d28145813
tree2a1732aef4633e1d474c4e70dbec1c2c6a35a55f
parentce397d215ccd07b8ae3f71db689aedb85d56ab40
ARM: mvebu: declare asm symbols as character arrays in pmsu.c

With CONFIG_FORTIFY_SOURCE, memcpy uses the declared size of operands to
detect buffer overflows.  If src or dest is declared as a char, attempts to
copy more than byte will result in a fortify_panic().

Address this problem in mvebu_setup_boot_addr_wa() by declaring
mvebu_boot_wa_start and mvebu_boot_wa_end as character arrays.  Also remove
a couple addressof operators to avoid "arithmetic on pointer to an
incomplete type" compiler error.

See commit 54a7d50b9205 ("x86: mark kprobe templates as character arrays,
not single characters") for a similar fix.

Fixes "detected buffer overflow in memcpy" error during init on some mvebu
systems (armada-370-xp, armada-375):

(fortify_panic) from (mvebu_setup_boot_addr_wa+0xb0/0xb4)
(mvebu_setup_boot_addr_wa) from (mvebu_v7_cpu_pm_init+0x154/0x204)
(mvebu_v7_cpu_pm_init) from (do_one_initcall+0x7c/0x1a8)
(do_one_initcall) from (kernel_init_freeable+0x1bc/0x254)
(kernel_init_freeable) from (kernel_init+0x8/0x114)
(kernel_init) from (ret_from_fork+0x14/0x2c)

Signed-off-by: Ethan Tuttle <ethan@ethantuttle.com>
Tested-by: Ethan Tuttle <ethan@ethantuttle.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
arch/arm/mach-mvebu/pmsu.c