dmaengine: pl330: Make sure the debug is idle before doing DMAGO
authorSugar Zhang <sugar.zhang@rock-chips.com>
Thu, 4 Jun 2020 01:36:38 +0000 (09:36 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 24 Jun 2020 07:41:26 +0000 (13:11 +0530)
commitd12ea5591eddf625b7707c018b72e46e8674c3c2
treee1b9c89db9de6b759e6d305fa5f23d2ce053dc38
parent0705107fcc80711680b169abc2011686dded6c21
dmaengine: pl330: Make sure the debug is idle before doing DMAGO

According to the datasheet of pl330:

Example 2-1 Using DMAGO with the debug instruction registers

1. Create a program for the DMA channel
2. Store the program in a region of system memory
3. Poll the DBGSTATUS Register to ensure that the debug is idle
4. Write to the DBGINST0 Register
5. Write to the DBGINST1 Register
6. Write zero to the DBGCMD Register

so, we should make sure the debug is idle before step 4/5/6, not
only step 6. if not, there maybe a risk that fail to write DBGINST0/1.

Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
Link: https://lore.kernel.org/r/1591234598-78919-1-git-send-email-sugar.zhang@rock-chips.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/pl330.c