PCI: qcom: Disable ASPM L0s for sc8280xp, sa8540p and sa8295p
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 6 Mar 2024 09:56:49 +0000 (10:56 +0100)
committerLorenzo Pieralisi <lpieralisi@kernel.org>
Fri, 8 Mar 2024 16:05:46 +0000 (17:05 +0100)
commitd1997c98781459f7b6d0bf1858f538f48454a97b
treea0bb2db9196fa5152fcb807174a752e0834fae9f
parent545e88cb41a69d705d5efacf0f96c3ca6e06e515
PCI: qcom: Disable ASPM L0s for sc8280xp, sa8540p and sa8295p

Commit 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting
1.9.0 ops") started enabling ASPM unconditionally when the hardware
claims to support it. This triggers Correctable Errors for some PCIe
devices on machines like the Lenovo ThinkPad X13s when L0s is enabled,
which could indicate an incomplete driver ASPM implementation or that
the hardware does in fact not support L0s.

This has now been confirmed by Qualcomm to be the case for sc8280xp and
its derivate platforms (e.g. sa8540p and sa8295p). Specifically, the PHY
configuration used on these platforms is not correctly tuned for L0s and
there is currently no updated configuration available.

Add a new flag to the driver configuration data and use it to disable
ASPM L0s on sc8280xp, sa8540p and sa8295p for now.

Note that only the 1.9.0 ops enable ASPM currently.

Link: https://lore.kernel.org/r/20240306095651.4551-4-johan+linaro@kernel.org
Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: stable@vger.kernel.org # 6.7
drivers/pci/controller/dwc/pcie-qcom.c