target/arm: Don't allow Thumb Neon insns without FEATURE_NEON
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 30 Apr 2020 18:09:29 +0000 (19:09 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 4 May 2020 11:57:56 +0000 (12:57 +0100)
commitd1a6d3b594157425232a1ae5ea7f51b7a1c1aa2e
tree50060d42bb37226d4bf92551bff59b2214dfb1e7
parent0d787cf1f3c88fa29477e054f8523f6d82d91c98
target/arm: Don't allow Thumb Neon insns without FEATURE_NEON

We were accidentally permitting decode of Thumb Neon insns even if
the CPU didn't have the FEATURE_NEON bit set, because the feature
check was being done before the call to disas_neon_data_insn() and
disas_neon_ls_insn() in the Arm decoder but was omitted from the
Thumb decoder.  Push the feature bit check down into the called
functions so it is done for both Arm and Thumb encodings.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20200430181003.21682-3-peter.maydell@linaro.org
target/arm/translate.c