media: i2c: ov7670: 0 instead of -EINVAL was returned
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Thu, 26 Jan 2023 13:03:51 +0000 (14:03 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Mar 2023 08:39:46 +0000 (09:39 +0100)
commitd2512e1c9073f61083fbf478a37f555ea7013afc
tree79899ab260ff4cb7acf59430969ae5fd3dca2877
parent29962c478e8b2e6a6154d8d84b8806dbe36f9c28
media: i2c: ov7670: 0 instead of -EINVAL was returned

[ Upstream commit 6a4c664539e6de9b32b65ddcf767ec1bcc1d7f8a ]

If the media bus is unsupported, then return -EINVAL. Instead it
returned 'ret' which happened to be 0.

This fixes a smatch warning:

ov7670.c:1843 ov7670_parse_dt() warn: missing error code? 'ret'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: 01b8444828fc ("media: v4l2: i2c: ov7670: Implement OF mbus configuration")
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/ov7670.c