mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref
authorPeter Griffin <peter.griffin@linaro.org>
Tue, 20 Feb 2024 11:50:10 +0000 (11:50 +0000)
committerLee Jones <lee@kernel.org>
Fri, 23 Feb 2024 16:02:02 +0000 (16:02 +0000)
commitd2b0680cf3b05490b579e71b0df6e07451977745
tree68d3314193b53470c6e76ec9dfacd0829f3e67ac
parent3e038941c58753c88f2dcc2b1744806ac8727bb2
mfd: syscon: Call of_node_put() only when of_parse_phandle() takes a ref

of_parse_phandle() returns a device_node with refcount incremented, which
the callee needs to call of_node_put() on when done. We should only call
of_node_put() when the property argument is provided though as otherwise
nothing has taken a reference on the node.

Fixes: 45330bb43421 ("mfd: syscon: Allow property as NULL in syscon_regmap_lookup_by_phandle")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20240220115012.471689-2-peter.griffin@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/syscon.c