projects / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 44c026a) | patch
module: Fix use-after-free bug in read_file_mod_stats()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fri, 28 Apr 2023 05:59:33 +0000 (22:59 -0700)
committerLuis Chamberlain <mcgrof@kernel.org>
Mon, 22 May 2023 21:13:13 +0000 (14:13 -0700)
commitd36f6efbe0cb422fe1e4475717d75f3737088832
tree1ab07fc5ff08142fb69becd47de6d6006548c712tree | snapshot
parent44c026a73be8038f03dbdeef028b642880cf1511commit | diff
module: Fix use-after-free bug in read_file_mod_stats()

Smatch warns:
kernel/module/stats.c:394 read_file_mod_stats()
warn: passing freed memory 'buf'

We are passing 'buf' to simple_read_from_buffer() after freeing it.

Fix this by changing the order of 'simple_read_from_buffer' and 'kfree'.

Fixes: df3e764d8e5c ("module: add debug stats to help identify memory pressure")
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
kernel/module/stats.c diff | blob | history
ep93xx device tree rework repo: git://git.maquefel.me/linux.git