dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key
authorTom Rix <trix@redhat.com>
Mon, 14 Feb 2022 15:41:39 +0000 (07:41 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Feb 2022 11:03:12 +0000 (12:03 +0100)
commitd3c9dd36ec2443b6841b0aa3194797dd89215430
tree276dafff3da777485a53d0c3cef415fc0420e755
parent1a16f047946b89a75d3d4c2d246f71c13d8131ac
dpaa2-switch: fix default return of dpaa2_switch_flower_parse_mirror_key

commit 2a36ed7c1cd55742503bed81d2cc0ea83bd0ad0c upstream.

Clang static analysis reports this representative problem
dpaa2-switch-flower.c:616:24: warning: The right operand of '=='
  is a garbage value
  tmp->cfg.vlan_id == vlan) {
                   ^  ~~~~
vlan is set in dpaa2_switch_flower_parse_mirror_key(). However
this function can return success without setting vlan.  So
change the default return to -EOPNOTSUPP.

Fixes: 0f3faece5808 ("dpaa2-switch: add VLAN based mirroring")
Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c