physmem: disallow direct access to RAM DEVICE in address_space_write_rom()
authorDavid Hildenbrand <david@redhat.com>
Mon, 10 Feb 2025 08:46:45 +0000 (09:46 +0100)
committerPeter Xu <peterx@redhat.com>
Wed, 12 Feb 2025 15:13:28 +0000 (10:13 -0500)
commitd4337aa8e222802d342b9f58440ca8e005b8bf91
tree98c8d3ccfa8f236f79c9a79a0968423a7b0d369f
parent7fd970a7d35af543992bf85e77b75de6b8125eb1
physmem: disallow direct access to RAM DEVICE in address_space_write_rom()

As documented in commit 4a2e242bbb306 ("memory: Don't use memcpy for
ram_device regions"), we disallow direct access to RAM DEVICE regions.

This change implies that address_space_write_rom() and
cpu_memory_rw_debug() won't be able to write to RAM DEVICE regions. It
will also affect cpu_flush_icache_range(), but it's only used by
hw/core/loader.c after writing to ROM, so it is expected to not apply
here with RAM DEVICE.

This fixes direct access to these regions where we don't want direct
access. We'll extend cpu_memory_rw_debug() next to also be able to write to
these (and IO) regions.

This is a preparation for further changes.

Cc: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20250210084648.33798-5-david@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
system/physmem.c