mfd: fsl-imx25: Fix check for platform_get_irq() errors
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 11 Aug 2022 10:53:05 +0000 (13:53 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 26 Oct 2022 10:35:18 +0000 (12:35 +0200)
commitd43d93dbd8aad34b30b446a5f637783160641333
tree99ff08e3decd41ae089bc3ed81745e0c2ed51a4a
parentb940bb3c81544f5f021e22114c39a22c96ef1a0d
mfd: fsl-imx25: Fix check for platform_get_irq() errors

[ Upstream commit 75db7907355ca5e2ff606e9dd3e86b6c3a455fe2 ]

The mx25_tsadc_remove() function assumes all non-zero returns are success
but the platform_get_irq() function returns negative on error and
positive non-zero values on success.  It never returns zero, but if it
did then treat that as a success.

Fixes: 18f773937968 ("mfd: fsl-imx25: Clean up irq settings during removal")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Martin Kaiser <martin@kaiser.cx>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/YvTfkbVQWYKMKS/t@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mfd/fsl-imx25-tsadc.c