s390/ism: ism driver implies smc protocol
authorGerd Bayer <gbayer@linux.ibm.com>
Wed, 15 Nov 2023 15:59:58 +0000 (16:59 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 17 Nov 2023 00:31:00 +0000 (00:31 +0000)
commitd565fa4300d9ebd5ba3bbd259ce841f8dab609d6
tree65257533aee74dab907164215f2c5293787b5a82
parent0c3bd086d12d185650d095a906662593ec607bd0
s390/ism: ism driver implies smc protocol

Since commit a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
you can build the ism code without selecting the SMC network protocol.
That leaves some ism functions be reported as unused. Move these
functions under the conditional compile with CONFIG_SMC.

Also codify the suggestion to also configure the SMC protocol in ism's
Kconfig - but with an "imply" rather than a "select" as SMC depends on
other config options and allow for a deliberate decision not to build
SMC. Also, mention that in ISM's help.

Fixes: a72178cfe855 ("net/smc: Fix dependency of SMC on ISM")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Closes: https://lore.kernel.org/netdev/afd142a2-1fa0-46b9-8b2d-7652d41d3ab8@infradead.org/
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/Kconfig
drivers/s390/net/ism_drv.c