media: driver: s3c_camif: move s3c_camif_unregister_subdev out of camif_unregister_me...
authorDongliang Mu <mudongliangabcd@gmail.com>
Tue, 19 Oct 2021 03:39:52 +0000 (05:39 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 30 Nov 2021 11:06:27 +0000 (12:06 +0100)
commitd5e9bddb28057615fed653dcfa25f96896b1ff04
tree92a77f5ceeb410b8a596560a969e5a6e6407722d
parent0529c0f55da87a338a07f3394f55c4873a937be6
media: driver: s3c_camif: move s3c_camif_unregister_subdev out of camif_unregister_media_entities

In the error handling of s3c_camif_probe, s3c_camif_unregister_subdev
may be executed twice, one is from camif_unregister_media_entities.
Although there is sanity check about the registration status,
it is not good to call s3c_camif_unregister_subdev twice in the error
handling code.

Fix this by moving s3c_camif_unregister_subdev out of
camif_unregister_media_entities, and add a s3c_camif_unregister_subdev
in the s3c_camif_remove.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/s3c-camif/camif-core.c