usb: storage: sddr55: fix sloppy typing in sddr55_{read|write}_data()
authorKarina Yankevich <k.yankevich@omp.ru>
Sun, 21 Jan 2024 17:29:55 +0000 (20:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 28 Jan 2024 00:44:00 +0000 (16:44 -0800)
commitd6429a3555fb29f380c5841a12f5ac3f7444af03
tree8032a319d6d49a245975c2563152cae6fec4b531
parent7626c52b6b461b44a46cea4d51b4cf749657f5a8
usb: storage: sddr55: fix sloppy typing in sddr55_{read|write}_data()

In sddr55_{read|write}_data(), the address variables are needlessly typed
as *unsigned long* -- which is 32-bit type on the 32-bit arches and 64-bit
type on the 64-bit arches; those variables' value should fit into just 3
command bytes and consists of 10-bit block # (or at least the max block #
seems to be 1023) and 4-/5-bit page # within a block, so 32-bit *unsigned*
*int* type should be more than enough...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

[Sergey: rewrote the patch subject/description]

Signed-off-by: Karina Yankevich <k.yankevich@omp.ru>
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/4c9485f2-0bfc-591b-bfe7-2059289b554e@omp.ru
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/storage/sddr55.c