cgroup.c: remove redundant check for mixable cgroup in cgroup_migrate_vet_dst
authorLin Feng <linf@wangsu.com>
Tue, 21 Jun 2022 09:23:58 +0000 (17:23 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 27 Jun 2022 09:09:21 +0000 (18:09 +0900)
commitd75cd55ae2dedeee5382bb48832c322673b9781c
treed8f8a82652f8f02c084cfed76dec14263702ebca
parente210a89f5b07680fe21d21e846e6817346c5ba3b
cgroup.c: remove redundant check for mixable cgroup in cgroup_migrate_vet_dst

We have:
int cgroup_migrate_vet_dst(struct cgroup *dst_cgrp)
{
...
/* mixables don't care */
if (cgroup_is_mixable(dst_cgrp))
return 0;

/*
 * If @dst_cgrp is already or can become a thread root or is
 * threaded, it doesn't matter.
 */
if (cgroup_can_be_thread_root(dst_cgrp) || cgroup_is_threaded(dst_cgrp))
return 0;
...
}

but in fact the entry of cgroup_can_be_thread_root() covers case that
checking cgroup_is_mixable() as following:
static bool cgroup_can_be_thread_root(struct cgroup *cgrp)
{
        /* mixables don't care */
        if (cgroup_is_mixable(cgrp))
                return true;
...
}

so explicitly checking in cgroup_migrate_vet_dst is unnecessary.

Signed-off-by: Lin Feng <linf@wangsu.com>
Reviewed-by: Michal Koutný <mkoutny@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/cgroup/cgroup.c