pc-bios/s390-ccw: Clean up harmless misuse of isdigit()
authorMarkus Armbruster <armbru@redhat.com>
Thu, 18 Apr 2019 14:53:54 +0000 (16:53 +0200)
committerThomas Huth <thuth@redhat.com>
Wed, 8 May 2019 08:52:14 +0000 (10:52 +0200)
commitd796588ba13b9d9301433bdf4e461ad5e60d9796
tree1c292cc038dbba4a2c3638bf5a55611f9331de52
parenta6f6d24757a73f7176989134b97284a1a7df11e5
pc-bios/s390-ccw: Clean up harmless misuse of isdigit()

atoui() and get_index() pass char values to isdigit().  With a
standard isdigit(), we'd get undefined behavior when the value is
negative.  Can't happen as char is unsigned on s390x.  Even if it
ould, we're actually using isdigit() from pc-bios/s390-ccw/libc.h
here, which works fine for negative values.  Clean up anyway, just
to avoid setting a bad example.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190418145355.21100-6-armbru@redhat.com>
[thuth: updated the commit message]
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/libc.c
pc-bios/s390-ccw/menu.c