mptcp: be careful on subflows shutdown
authorPaolo Abeni <pabeni@redhat.com>
Wed, 9 Dec 2020 11:03:31 +0000 (12:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 10 Dec 2020 03:31:58 +0000 (19:31 -0800)
commitd7b1bfd0832c1d005f571203306b6c50e9805150
tree4835210f79ccb092abb8aff17daecae4f21acd38
parent0597d0f8e030d1a5e64708b0f3233209a8b5d39e
mptcp: be careful on subflows shutdown

When the workqueue disposes of the msk, the subflows can still
receive some data from the peer after __mptcp_close_ssk()
completes.

The above could trigger a race between the msk receive path and the
msk destruction. Acquiring the mptcp_data_lock() in __mptcp_destroy_sock()
will not save the day: the rx path could be reached even after msk
destruction completes.

Instead use the subflow 'disposable' flag to prevent entering
the msk receive path after __mptcp_close_ssk().

Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close")
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.c