media: atomisp: Fix deadlock when the /dev/video# node is closed while still streaming
authorHans de Goede <hdegoede@redhat.com>
Sun, 23 Oct 2022 20:22:14 +0000 (21:22 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 25 Nov 2022 08:19:24 +0000 (08:19 +0000)
commitda0dd507fa279c33813ae6f28e47c61ce065586c
tree461e3fb646dbeaaf2826c27bbb1260c19f53a7cd
parentac8dd062aa6cb095096e02240f497786891317b0
media: atomisp: Fix deadlock when the /dev/video# node is closed while still streaming

atomisp_release() was taking pipe->vb_queue_mutex + isp->mutex at the
same time. But if the /dev/video# node is closed while still streaming
then vb2_queue_release() will call atomisp_stop_streaming() which takes
isp->mutex itself, leading to a deadlock.

To fix this only take isp->mutex after cleaning up the v4l2_fh /
the vb2_queue. While at it switch to vb2_fop_release() which will take
pipe->vb_queue_mutex for us, which also resolves a FIXME comment.

Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_fops.c