selftests/bpf: Make linked_list failure test more robust
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Fri, 20 Oct 2023 14:48:39 +0000 (14:48 +0000)
committerAndrii Nakryiko <andrii@kernel.org>
Fri, 20 Oct 2023 16:29:39 +0000 (09:29 -0700)
commitda1055b673f3baac2249571c9882ce767a0aa746
tree090defa9c2720728459a37c332274a8a085fce4b
parentbab8ac3c5339d7ec5312dcd836cfa8645edb954f
selftests/bpf: Make linked_list failure test more robust

The linked list failure test 'pop_front_off' and 'pop_back_off'
currently rely on matching exact instruction and register values.  The
purpose of the test is to ensure the offset is correctly incremented for
the returned pointers from list pop helpers, which can then be used with
container_of to obtain the real object. Hence, somehow obtaining the
information that the offset is 48 will work for us. Make the test more
robust by relying on verifier error string of bpf_spin_lock and remove
dependence on fragile instruction index or register number, which can be
affected by different clang versions used to build the selftests.

Fixes: 300f19dcdb99 ("selftests/bpf: Add BPF linked list API tests")
Reported-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20231020144839.2734006-1-memxor@gmail.com
tools/testing/selftests/bpf/prog_tests/linked_list.c
tools/testing/selftests/bpf/progs/linked_list_fail.c