soc: renesas: rcar-sysc: Add goto to of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Thu, 15 Aug 2019 06:13:54 +0000 (11:43 +0530)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 19 Aug 2019 12:56:14 +0000 (14:56 +0200)
commitda51ceda8ab054bf3b4c5cf86a8deec7d7849a5c
treee629a5b0badaaf10590010cbb38a8841e6fbfb07
parent0ed0eb0171d7c19310d9f7b06a6dee82a4fb8ab6
soc: renesas: rcar-sysc: Add goto to of_node_put() before return

The local variable np in function rcar_sysc_pd_init takes the return
value of of_find_matching_node_and_match(), which gets a node but does
not put it.  If np is not put before the function returns, it may cause
a memory leak.

Hence, remove the return statement that does not immediately follow a
putting of np.  Replace it with a goto pointing to a pre-existing label
that first puts np and then returns the required value.

Issue found with Coccinelle.

Fixes: afa6f53df6052968 ("soc: renesas: rcar-sysc: Add support for fixing up power area tables")
Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/soc/renesas/rcar-sysc.c